Skip to content

8385955: [lworld] Drop initialization warnings#2512

Closed
mcimadamore wants to merge 2 commits into
openjdk:lworldfrom
mcimadamore:drop_init_warnings
Closed

8385955: [lworld] Drop initialization warnings#2512
mcimadamore wants to merge 2 commits into
openjdk:lworldfrom
mcimadamore:drop_init_warnings

Conversation

@mcimadamore
Copy link
Copy Markdown
Collaborator

@mcimadamore mcimadamore commented Jun 4, 2026 •
edited by openjdk Bot
Loading

After some more analysis, we have decided to drop the initialization warning from the initial JEP 401 integration.

First, the definition of initialization warnings is a little ambiguous, as it can mean one of two things:

  • pretend super() was at the bottom of a constructor, and see what happens
  • pretend all fields were strict, and see what happens

These two things are not identical, and lead to a different sets of warnings being generated.

Secondly, there's a lot of noise with these warnings:

  • JDK code contains ~67 suppressions
  • if we tweak the code to also report the warning when --enable-preview is disabled, an additional 80+ warnings show up during an early phase of the build (but there's possibly many many more)

For the time being, we'll revert the code that issues the new warnings, related tests and suppressions.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8385955: [lworld] Drop initialization warnings (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2512/head:pull/2512
$ git checkout pull/2512

Update a local copy of the PR:
$ git checkout pull/2512
$ git pull https://git.openjdk.org/valhalla.git pull/2512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2512

View PR using the GUI difftool:
$ git pr show -t 2512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2512.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jun 4, 2026

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 4, 2026 •
edited
Loading

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8385955: [lworld] Drop initialization warnings

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • a7567f2: 8385943: [lworld] Redundant ValueBased annotation on Record
  • 74f27eb: 8385916: [lworld] Cherry-pick JDK-8377808 and remove problemlisting
  • 0639bc3: 8375563: [lworld] java/util/Collection/IteratorAtEnd.java fails with IllegalStateException

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

liach
liach approved these changes Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@vicente-romero-oracle
Copy link
Copy Markdown
Contributor

vicente-romero-oracle commented Jun 4, 2026

please compare with the PR that introduced it: #1650, there are other files that should be modified, for example:
src/jdk.compiler/share/classes/module-info.java
src/jdk.compiler/share/man/javac.md

@mcimadamore
Copy link
Copy Markdown
Collaborator Author

mcimadamore commented Jun 4, 2026

/template append

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 4, 2026

@mcimadamore The pull request template has been appended to the pull request body

@mcimadamore mcimadamore changed the title 8385955: Drop initialization warnings 8385955: [lworld] Drop initialization warnings Jun 4, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Jun 4, 2026

Webrevs

@mcimadamore
Copy link
Copy Markdown
Collaborator Author

mcimadamore commented Jun 4, 2026

please compare with the PR that introduced it: #1650, there are other files that should be modified, for example: src/jdk.compiler/share/classes/module-info.java src/jdk.compiler/share/man/javac.md

Good catch! Addressed in 1c548ee

@mcimadamore
Copy link
Copy Markdown
Collaborator Author

mcimadamore commented Jun 4, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 4, 2026

Going to push as commit 2ad1916.
Since your change was applied there have been 5 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jun 4, 2026
@openjdk openjdk Bot closed this Jun 4, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 4, 2026

@mcimadamore Pushed as commit 2ad1916.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liach liach liach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcimadamore @vicente-romero-oracle @liach